Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPT Dashboard Bugs #113

Merged
merged 8 commits into from
Aug 30, 2024
Merged

CPT Dashboard Bugs #113

merged 8 commits into from
Aug 30, 2024

Conversation

MVarshini
Copy link
Collaborator

Type of change

  • Refactor
  • New feature
  • Bug fix
  • Optimization
  • Documentation Update

Description

The following bugs are fixed in this PR

  • Missing First row border in OCP, Telco, Quay tabs
  • Node keys mapping in OCP and Quay Tabs
  • Quay Filters
  • Telco Graphs

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please describe the System Under Test.
  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@MVarshini MVarshini self-assigned this Aug 30, 2024
vishnuchalla
vishnuchalla approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@vishnuchalla vishnuchalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Further improvements are minor and can be taken in follow up PRs.

@vishnuchalla vishnuchalla merged commit e9d79cb into cloud-bulldozer:revamp Aug 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishnuchalla vishnuchalla vishnuchalla approved these changes

@chentex chentex Awaiting requested review from chentex

Assignees

@MVarshini MVarshini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MVarshini @vishnuchalla